Skip to content

Fix get_dependencies(), add poutine.get_plates()#2933

Merged
eb8680 merged 4 commits into
devfrom
fix-get-dependencies
Sep 21, 2021
Merged

Fix get_dependencies(), add poutine.get_plates()#2933
eb8680 merged 4 commits into
devfrom
fix-get-dependencies

Conversation

@fritzo
Copy link
Copy Markdown
Member

@fritzo fritzo commented Sep 21, 2021

Blocking #2929

This PR adds some fixes and machinery needed for #2929, aiming to simplify that growing PR.

  • makes a number of fixes to get_inspect(), adding regression tests:
    • support for pyro.factor() statements
    • support for discrete variables
    • support for use inside torch.no_grad(), as in autoguide init
  • adds a poutine.get_plates() and adds unit tests (also adds tests for poutine.get_mask())
  • fixes a typo in the Logistic distribution
  • works around coveralls flakiness

Copy link
Copy Markdown
Member

@eb8680 eb8680 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@eb8680 eb8680 merged commit 0dc22d6 into dev Sep 21, 2021
@eb8680 eb8680 deleted the fix-get-dependencies branch September 21, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants