Merged
Conversation
added 3 commits
November 13, 2017 16:36
Triggers a regression introduced during refactoring of the multicall loop. Demonstrates the issue described in pytest-dev#99.
Multi-call loop(s) should not care about spec opts - only whether or not the first result should be returned. Fix issue where a collected but unmarked hook not having `_HookCaller.spec_opts` defined results in an attr error. Resolves pytest-dev#99
RonnyPfannschmidt
approved these changes
Nov 18, 2017
Member
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
nicely found, good work 👍
| self._wrappers = [] | ||
| self._nonwrappers = [] | ||
| self._hookexec = hook_execute | ||
| self._specmodule_or_class = None |
This was referenced Nov 24, 2017
This was referenced Dec 8, 2017
This was referenced Dec 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #99 as well as removes any direct references to
_HookCallerinside of the multi call loops.This makes the call loops fully self contained without requiring any knowledge of overlying abstractions.