Merged
Conversation
added 4 commits
May 22, 2018 17:30
test_hookcaller.py: We're not testing "method ordering" per say, we're testing the general internal API and behaviour of the `_HookCaller`; its method ordering is the majority of its purpose, yes. There's also a bunch of tests in this module that don't belong. test_invocations.py: You can't really test the "hookrelay" (unless you're trying to test `getattr`). Really this module is testing the different types of hook "invocations" in terms of API and execution behaviour. Resolves pytest-dev#100
Contributor
Author
|
@RonnyPfannschmidt @nicoddemus this is ready for viewing I believe. |
RonnyPfannschmidt
approved these changes
May 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #100 as well as attempts to bring a little more consistency and appropriate organization to our test module's content. See the commit msg in 4c19d8d for the details on the two module (re)namings.
This should at the least make it easier to find tests related to specific components and help us avoid duplication (of which I still think there is some but fixing that will come later).
I also moved a bunch of tests from the
test_method_ordering(nowtest_hookcaller) intotest_pluginmanageras they really are just tests of the public API for both tracing and thesetuptoolsentry point loading stuff.I added a specific module for deprecation warnings tests.
There's further deprecation tests in
test_pluginmanager.pynow that #144 has landed.I wasn't sure if it'd be appropriate to move these into
test_deprecationsnow or if that module should be strictly for warnings tests.test_detailsis also something we might want to rename as it doesn't convey much meaning.