Skip to content

Fix error while issuing DeprecationWarning for __multicall__ usage #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RonnyPfannschmidt merged 3 commits into from
Aug 31, 2017
Merged

Fix error while issuing DeprecationWarning for __multicall__ usage #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
672a98b
Fix error while issuing DeprecationWarning for __multicall__ usage
nicoddemus Aug 30, 2017
dc6ae62
Use function-form of deprecated_call to comply with older pytest vers…
nicoddemus Aug 30, 2017
bf3f0ba
Simplify test
nicoddemus Aug 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pluggy/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@ def _add_hookimpl(self, hookimpl):
warnings.warn(
"Support for __multicall__ is now deprecated and will be"
"removed in an upcoming release.",
warnings.DeprecationWarning
DeprecationWarning
)
self.multicall = _LegacyMultiCall

Expand Down
9 changes: 9 additions & 0 deletions testing/test_pluginmanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,15 @@ class PluginNo(object):
assert l == [10]


def test_multicall_deprecated(pm):
class P1(object):
@hookimpl
def m(self, __multicall__, x):
pass

pytest.deprecated_call(pm.register, P1())


def test_add_hookspecs_nohooks(pm):
with pytest.raises(ValueError):
pm.add_hookspecs(10)