Avoid using py.std to import fnmatch.#99
Merged
RonnyPfannschmidt merged 1 commit intopytest-dev:masterfrom Dec 20, 2016
pelme:fnmatch-import
Merged
Avoid using py.std to import fnmatch.#99RonnyPfannschmidt merged 1 commit intopytest-dev:masterfrom pelme:fnmatch-import
RonnyPfannschmidt merged 1 commit intopytest-dev:masterfrom
pelme:fnmatch-import
Conversation
fnmatch is used from the pytest ast hook which may trigger an import from the import hook. This leads to endless recursion. Avoiding py.std avoids the problem. See pytest-dev/pytest#2121 for more information.
This was referenced Dec 17, 2016
Closed
Member
|
this will add early init cost |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fnmatch is used from the pytest ast hook which may trigger an import
from the import hook. This leads to endless recursion. Avoiding py.std
avoids the problem.
See pytest-dev/pytest#2121 for more
information.