Allow Examples table to include values not used in steps#391
Allow Examples table to include values not used in steps#391hicksjduk wants to merge 10 commits intopytest-dev:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #391 +/- ##
==========================================
+ Coverage 95.93% 95.95% +0.01%
==========================================
Files 50 50
Lines 1649 1656 +7
Branches 149 149
==========================================
+ Hits 1582 1589 +7
Misses 41 41
Partials 26 26 ☔ View full report in Codecov by Sentry. |
|
@youtux, it seems that you were the last person to touch this code. Would you be able to review this PR, or else how do I request a review given that I don't have write access to the repo? |
|
@hicksjduk Could you please rename the pull request to something like "Allow store values in Examples not used in steps" to show the real value of this feature @youtux Please review |
hicksjduk
changed the title
|
Done. |
Changed validation of a scenario against its examples table so that the list of parameters defined for the scenario does not have to be the same as the list of parameters defined in the examples table, but can be a subset. This allows columns to be specified in the examples table that are not used in the scenario, but are there for future use or purely for documentation purposes.
hicksjduk
force-pushed
the
fix-examples-error
branch
from
43da4e8 to
f9d775f
Compare
olegpidsadnyi
left a comment
olegpidsadnyi
left a comment
There was a problem hiding this comment.
Cucumber (gherkin lint) uses no-unused-variables rule to optionally raise on this. @youtux Do you think we need to make it an option?
Isn't this a rule in the linter that checks the implementation code? Not in the functionality that implements the gherkin bindings. I can't find any reference in the cucumber documentation to this rule. |
|
@hicksjduk Oleg means https://www.npmjs.com/package/gherkin-lint |
|
I think we should just allow examples to include values that are not used. I wouldn't make it an option, I find it unnecessary complication. |
for more information, see https://pre-commit.ci
|
@olegpidsadnyi please review |
|
@youtux I don't think this restriction exists in the code base any more, from what I can see? I can also see there is a test: test_unused_params - is this covered by this test? |
|
yes exactly this can be closed indeed |
5 participants
See #390 for a description of the error to which this is a fix.