Skip to content

Fix missing step parameter substitution#519

Closed
elchupanebrej wants to merge 1 commit intopytest-dev:masterfrom
elchupanebrej:fix_missing_parameter_substitution
Closed

Fix missing step parameter substitution#519
elchupanebrej wants to merge 1 commit intopytest-dev:masterfrom
elchupanebrej:fix_missing_parameter_substitution

Conversation

@elchupanebrej
Copy link

This defect blocks allure-pytest-bdd plugin to work with pytest>5.0

allure-framework/allure-python#660

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #519 (b8579f2) into master (a75fc05) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
+ Coverage   92.69%   92.72%   +0.03%     
==========================================
  Files          48       48              
  Lines        1642     1650       +8     
  Branches      176      176              
==========================================
+ Hits         1522     1530       +8     
  Misses         82       82              
  Partials       38       38              
Impacted Files Coverage Δ
pytest_bdd/parser.py 97.94% <100.00%> (+0.03%) ⬆️
tests/feature/test_steps.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a75fc05...b8579f2. Read the comment docs.

@elchupanebrej elchupanebrej force-pushed the fix_missing_parameter_substitution branch from ee81bc4 to b8579f2 Compare May 13, 2022 13:44
@elchupanebrej elchupanebrej marked this pull request as ready for review May 13, 2022 13:44
@youtux
Copy link
Contributor

youtux commented Jul 4, 2022

Hi, I instead fixed the problem by parsing the <...> text only in Scenario Outline (#524)

@youtux youtux closed this Jul 4, 2022
@youtux
Copy link
Contributor

youtux commented Jul 4, 2022

I hope this fixes the issue with allure-pytest-bdd

@youtux
Copy link
Contributor

youtux commented Jul 4, 2022

I just published version 6.0.0 of pytest-bdd, which includes this fix.

@elchupanebrej elchupanebrej deleted the fix_missing_parameter_substitution branch July 1, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants