Only use the official Gherkin parser objects and remove custom parser logic#699
Closed
jsa34 wants to merge 17 commits intopytest-dev:masterfrom
Closed
Only use the official Gherkin parser objects and remove custom parser logic#699jsa34 wants to merge 17 commits intopytest-dev:masterfrom
jsa34 wants to merge 17 commits intopytest-dev:masterfrom
Conversation
…n public API and current codebase as much as possible)
…f available data and implementing features.
…s removing tabbing from docstring in steps (aka multiline steps)
Collaborator
Author
|
I'm thinking a different approach might be better to keep the DAO/mapping and logic encapsulated |
…cessing where not needed
|
🧙 Sourcery has finished reviewing your pull request! Tips
|
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Collaborator
Author
|
Closed to focus on parser, and ended up just dumping things I was trying on this branch - apologies! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going a step further than my previous PR that simply parsed the feature files using the official parser, but then copied this data into the existing parser objects, this PR removes the old parser completely and either uses the data directly that is parsed into the models from the Gherkin parser or adds needed functionality to the Gherkin parser models to enhance just being DAOs for pytest-bdd to use the data as it needs to.