Only test against a single recent pytest and coverage.py#182
Closed
hugovk wants to merge 3 commits intopytest-dev:masterfrom
Closed
Only test against a single recent pytest and coverage.py#182hugovk wants to merge 3 commits intopytest-dev:masterfrom
hugovk wants to merge 3 commits intopytest-dev:masterfrom
Conversation
Member
|
Some fair arguments here, I'll include some of these changes (#178 already drops some stuff out). |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to suggest running 146 build jobs is a bit unweildy. It uses nearly 7 hours of CI time in total, about 1.5 hours from start to finish (eg.).
It's testing 6 Python versions against 4 pytest versions and 6 coverage.py versions (plus 2 for docs/checks), 6 * 4 * 6 + 2=146.
Is it really necessary to test against all those old versions of pytest and coverage.py?
Does pytest-cov need to make promises to support so old releases?
Does pytest promise to support 3 old releases, or coverage.py 5 old releases, or just the most recent?
Further, some three dozen of the build jobs are failing, giving less confidence in the CI/tests as a whole.
https://docs.travis-ci.com/user/customizing-the-build/#Build-Matrix says:
I'd recommend only testing against a single, recent version of pytest and coverage.py, 6 * 1 * 1 + 2=8, only about 22 minutes total and 6 minutes start to finish (eg.). Of course, I don't know the full history, so perhaps one old extra version may be necessary, but 146 seems a bit much.
Thank you!