Fix comparison against installed PyTest version#353
Closed
michaelmanganiello-eb wants to merge 1 commit intopytest-dev:masterfrom
Closed
Fix comparison against installed PyTest version#353michaelmanganiello-eb wants to merge 1 commit intopytest-dev:masterfrom
michaelmanganiello-eb wants to merge 1 commit intopytest-dev:masterfrom
Conversation
With the current code, the comparison `pytest.__version__ >= '3.8'` returns the wrong result when using PyTest 3.10, as `'3.10' < '3.8'` if we use Python's string comparison. Having `PYTEST_VERSION` as an integer tuple allows us to have simpler comparisons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the current code, introduced in #230, the comparison
pytest.__version__ >= '3.8'returns the wrong result when usingPyTest 3.10, as
'3.10' < '3.8'if we use Python's string comparison.Having
PYTEST_VERSIONas an integer tuple allows us to have simplercomparisons.
This fixes the following warning when using PyTest 3.10: