Skip to content

Django 2.0 ImportError on django.core.urlresolvers#518

Merged
blueyed merged 1 commit intopytest-dev:masterfrom
jpic:patch-1
Sep 29, 2017
Merged

Django 2.0 ImportError on django.core.urlresolvers#518
blueyed merged 1 commit intopytest-dev:masterfrom
jpic:patch-1

Conversation

@jpic
Copy link
Contributor

@jpic jpic commented Sep 23, 2017

No description provided.

try:
from django.core.urlresolvers import clear_url_caches, set_urlconf
except ImportError:
from django.urls import clear_url_caches, set_urlconf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it prefer the new version?

@blueyed
Copy link
Contributor

blueyed commented Sep 23, 2017

Also a comment would make sense here.

@jpic jpic force-pushed the patch-1 branch 2 times, most recently from 20cfeb4 to 3c6def2 Compare September 25, 2017 12:02
@blueyed blueyed merged commit 84c27a0 into pytest-dev:master Sep 29, 2017
@blueyed
Copy link
Contributor

blueyed commented Sep 29, 2017

Thanks @jpic!

@blueyed
Copy link
Contributor

blueyed commented Sep 29, 2017

btw: I would like to get coverage reporting in (#520) and then make it ready for Django 2.0 in general. Can you take a look at #520, please?

ashwoods pushed a commit to ashwoods/pytest-django that referenced this pull request Oct 11, 2017
dulacp pushed a commit to dulacp/pytest-django that referenced this pull request Dec 2, 2017
timb07 pushed a commit to timb07/pytest-django that referenced this pull request May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants