Skip to content

WIP: bisect pytest-cov#656

Closed
blueyed wants to merge 16 commits intopytest-dev:masterfrom
blueyed:bisect-pytest-cov
Closed

WIP: bisect pytest-cov#656
blueyed wants to merge 16 commits intopytest-dev:masterfrom
blueyed:bisect-pytest-cov

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Sep 16, 2018

No description provided.

export _PYTESTDJANGO_TOX_EXTRA_DEPS='https://github.com/pytest-dev/pytest-cov/archive/58c3ef15075a24077a2395b0edf0a6952c956d33.tar.gz'
else
PYTEST_DJANGO_COVERAGE=0
fi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blueyed
Copy link
Contributor Author

blueyed commented Sep 16, 2018

First bad commit: pytest-dev/pytest-cov@6b1e878

if [[ "$SKIP_COVERAGE" != "1" ]]; then
PYTEST_DJANGO_COVERAGE=1
export PYTEST_ADDOPTS='-x --cov=pytest_django --cov=tests --cov=pytest_django_test --cov-report=term-missing:skip-covered'
export PYTEST_ADDOPTS='-x --cov-branch --cov=pytest_django --cov=tests --cov=pytest_django_test --cov-report=term-missing:skip-covered'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought this might help, but should default to None.

@blueyed
Copy link
Contributor Author

blueyed commented Sep 16, 2018

Related: unsetting PYTEST_ADDOPTS (with pytest-cov options) for tests using testdir fixtures (i.e. the pytest subprocess) increased coverage (for early plugin stuff): #655 ?!

@blueyed blueyed mentioned this pull request Sep 16, 2018
@blueyed
Copy link
Contributor Author

blueyed commented Sep 17, 2018

Closing in favor of #657.

@blueyed blueyed closed this Sep 17, 2018
@blueyed blueyed deleted the bisect-pytest-cov branch September 17, 2018 06:49
@blueyed blueyed restored the bisect-pytest-cov branch September 21, 2018 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant