DB blocker: use RuntimeError instead of pytest.fail#781
Merged
blueyed merged 2 commits intopytest-dev:masterfrom Nov 1, 2019
Merged
DB blocker: use RuntimeError instead of pytest.fail#781blueyed merged 2 commits intopytest-dev:masterfrom
blueyed merged 2 commits intopytest-dev:masterfrom
Conversation
pytest fails to handle `pytest.fail.Exception` when raised in `repr`. This changes pytest-django to raise `RuntimeError` instead. Ref: pytest-dev/pytest#6020 Fixes pytest-dev#713
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest fails to handle
pytest.fail.Exceptionwhen raised inrepr, resultingin confusing "INTERNALERROR" messages, hiding the real failure (since it
happens during reporting).
This changes pytest-django to raise
RuntimeErrorinstead.While this will be fixed via
pytest-dev/pytest#6047 likely, it might be good
to have this anyway (also for older pytest versions).
Fixes #713
Fixes #341