Get rid of --instafail commandline argument?

[The-Compiler]

Thanks a lot for this plugin! It probably saved me countless hours of waiting for my testsuite to finish 🙂

I assume most testsuites with pytest-instafail installed will always want to enable it. This can be done with addopts = --instafail in a pytest.ini.

However, at that point the pytest-instafail plugin needs to be installed for the tests to work at all, which is a bit unfortunate. What do you think about enabling it when installed by default, similar to what e.g. pytest-sugar does? That would avoid this issue, and it's still possible to disable it using pytest's -p no:instafail.

[jeffwright13]

I was in agreement at first, but then reconsidered from the point of view of my job. We work in an automated test environment where all our dependencies are mandated during installation. If we were to add pytest-instafail as a dependency and there was no way to turn it off, the complaints from other testers would probably be loud. :-) It's not that the information being shown isn't valuable, it's the fact that testers are often creatures of comfort and don't want to see anything new unless they themselves were the ones to enable it. So based on that, I vote the keeping the behavior as it is now.

[ssbarnea]

@jeffwright13 Having a config option other than the CLI argument can be seen a one that would address the conflict between different usage scenarios.

For example I hate having to add --instafail to add_opts because execution will fail with plugin missing, but if that would an different config option, it would just be ignored in the absence of the plugin.