Fix SetupState breakage with upcoming pytest 6.3#151
Merged
icemac merged 3 commits intopytest-dev:masterfrom Feb 15, 2021
Merged
Fix SetupState breakage with upcoming pytest 6.3#151icemac merged 3 commits intopytest-dev:masterfrom
icemac merged 3 commits intopytest-dev:masterfrom
Conversation
bluetech
force-pushed
the
pytest63
branch
2 times, most recently
from
381ada9 to
9582da1
Compare
pytest 6.3 makes some changes to the SetupState class, adjust to that.
icemac
reviewed
Feb 10, 2021
| pytest60: pytest==6.0.* | ||
| pytest61: pytest==6.1.* | ||
| pytest62: pytest==6.2.* | ||
| pytestmaster: git+https://github.com/pytest-dev/pytest.git@master#egg=pytest |
Contributor
There was a problem hiding this comment.
I like testing against master.
This change should also be applied to .github/workflows/test.yml so CI runs them, too.
Member
Author
There was a problem hiding this comment.
Sure, added. Using master might of course cause breakage from the pytest side, but hopefully not.
icemac
approved these changes
Feb 15, 2021
Contributor
icemac
left a comment
icemac
left a comment
There was a problem hiding this comment.
Thank you for this PR and improving the test setup for this plug-in.
I like it.
Contributor
|
Thank you for this PR and the review. 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest 6.3 makes some changes to the SetupState class, adjust to that.