Fix regression with custom arguments being dropped in non-local executions

[ionelmc]

This fixes regression from #448 but lets see if it breaks other stuff.

[nicoddemus]

Thanks @ionelmc! It seems #448 unintentionlly also threw away pytest-xdist's own options, correct?

Any chance of writing an acceptance test that reproduces the problem to avoid future regressions (like this one in fact)?

We can ignore the py34 failures on Windows for now, it is unrelated and should be fixed/investigated seperately.

[ionelmc]

@nicoddemus I extended the chdir test to cover the hook problem.

[ionelmc]

Also, I didn't change the CHANGELOG.rst cause I don't really understand what that function does, or what the implications are.

[nicoddemus]

Also, I didn't change the CHANGELOG.rst cause I don't really understand what that function does, or what the implications are.

No worries, thanks a lot for tackling this, we appreciate it. 👍

I will take a look later.

[RonnyPfannschmidt]

giving it a preliminary approval even thou i want to see a additional change, happy sorting out this one

[RonnyPfannschmidt]

i understand the need for this hack, please add a comment linking this fun hack with the test id

[RonnyPfannschmidt]

also extra note, i caught a glimpse of the real issue and i recoil thinking about how to make it possible to fix it

the config init keeps giving and giving

[nicoddemus]

@RonnyPfannschmidt hmm even updating virtualenv didn't help. Any other ideas? I'm fine with removing py34 testing from Windows if we can't figure this out.

[RonnyPfannschmidt]

@nicoddemus based on the errors, its using a different virtualenv than the one we have gotten installed, due to path issues, i believe its an indication the builds scripts are fundamentally wrong, if we take off py34, we should take it off everywhere

[nicoddemus]

i believe its an indication the builds scripts are fundamentally wrong, if we take off py34

Which "build scripts" you mean? Note that we test using plain tox, without intermediate scripts.

[RonnyPfannschmidt]

@nicoddemus i looke in the wrong place, but as far as i can tell we dont update virtualenv

it might help to use tox-venv

[nicoddemus]

Thanks again @ionelmc, and sorry for the delay on this.

I've changed the test so it creates the plugin locally instead of installing it via pip -e.

I will rebase, merge, and make a new release once everything passes. 👍