PyPy version 6.0.0 have different offset in SyntaxError exception

[onovy]

PyPy version 6.0.0 have different offset in SyntaxError exception, see:

$ pypy
Python 2.7.13 (6.0.0+dfsg-1, Apr 27 2018, 22:07:01)
[PyPy 6.0.0 with GCC 7.3.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>>> try:
....     eval('xyz xyz')
.... except SyntaxError as e:
....     print(e.offset)
....
5

This breaks tests: testing/code/test_source.py::test_syntaxerror_rerepresentation

with error:

> ______________________ test_syntaxerror_rerepresentation _______________________
> 
>     def test_syntaxerror_rerepresentation():
>         ex = pytest.raises(SyntaxError, _pytest._code.compile, 'xyz xyz')
>         assert ex.value.lineno == 1
> >       assert ex.value.offset in (4, 7)  # XXX pypy/jython versus cpython?
> E       AssertionError: assert 5 in (4, 7)
> E        +  where 5 = SyntaxError('xyz xyz\n     ^\n(code was compiled probably from here: <69-codeg...C7rT/pytest-3.3.2/.pybuild/pypy_6.0_pytest/build/_pytest/python_api.py:589>)',).offset
> E        +    where SyntaxError('xyz xyz\n     ^\n(code was compiled probably from here: <69-codeg...C7rT/pytest-3.3.2/.pybuild/pypy_6.0_pytest/build/_pytest/python_api.py:589>)',) = <ExceptionInfo SyntaxError tblen=3>.value
> 
> ../../../testing/code/test_source.py:120: AssertionError

Fixed in Debian: bug commit

[pytestbot]

GitMate.io thinks possibly related issues are #2242 (different behavior for pytest xfail in 2.9.2 version and 3.0.6 ), #3144 (Exit exception), #561 (SyntaxError in docs), and #988 (With py.test raises on python2.6, weird exception instances).

[nicoddemus]

Thanks! We will apply the same patch once we start testing with PyPy 6.0!

[Zac-HD]

pytest/testing/code/test_source.py

Lines 119 to 124 in 38538c6

	def test_syntaxerror_rerepresentation() -> None:
	ex = pytest.raises(SyntaxError, _pytest._code.compile, "xyz xyz")
	assert ex is not None
	assert ex.value.lineno == 1
	assert ex.value.offset in {5, 7} # cpython: 7, pypy3.6 7.1.1: 5
	assert ex.value.text == "xyz xyz\n"