console_output_style=classic missing tests and seems broken since 3.4.0

[okken]

Thanks for submitting an issue!

Here's a quick checklist in what to include:

• Include a detailed description of the bug or suggestion
  console_output_style=classic seems to leave the progress indicator in place, but just leave it at 0%.
  This worked in pytest 3.3 versions.

I couldn't find any tests for this feature. Which may be why it wasn't caught earlier.

• pip list of the virtual environment you are using

(venv) $ pip list
Package        Version
-------------- -------
atomicwrites   1.2.0  
attrs          18.1.0 
click          6.7    
more-itertools 4.3.0  
pip            18.0   
pluggy         0.7.1  
py             1.5.4  
pytest         3.7.2  
setuptools     39.0.1 
six            1.11.0 
tinydb         3.11.0 

• pytest and operating system versions

platform darwin -- Python 3.7.0, pytest-3.7.2, py-1.5.4, pluggy-0.7.1
but seems broken starting with pytest 3.4.0

• Minimal example if possible

(venv) $ pip install pytest==3.7.2
...
Successfully installed pluggy-0.7.1 pytest-3.7.2
(venv) $ pytest --tb=no -o console_output_style=classic
===================== test session starts ======================
platform darwin -- Python 3.7.0, pytest-3.7.2, py-1.5.4, pluggy-0.7.1
rootdir: /Users/okken/projects/book/pytest_update/Book/code/ch1, inifile: pytest.ini
collected 6 items                                              

test_one.py .                                            [  0%]
test_two.py F                                            [  0%]
tasks/test_four.py ..                                    [  0%]
tasks/test_three.py ..

============== 1 failed, 5 passed in 0.10 seconds ==============
(venv) $ pip install pytest==3.3.2
...
Successfully installed pluggy-0.6.0 pytest-3.3.2
(venv) $ pytest --tb=no -o console_output_style=classic
===================== test session starts ======================
platform darwin -- Python 3.7.0, pytest-3.3.2, py-1.5.4, pluggy-0.6.0
rootdir: /Users/okken/projects/book/pytest_update/Book/code/ch1, inifile: pytest.ini
collected 6 items                                              

test_one.py .
test_two.py F
tasks/test_four.py ..
tasks/test_three.py ..

============== 1 failed, 5 passed in 0.09 seconds ==============

[nicoddemus]

Thanks @okken! It seems few people tried to revert to the classic style if only now someone noticed this has been broken for awhile. 😅