TestReport.user_properties is documented as a list, actually a tuple

[Zac-HD]

pytest/src/_pytest/reports.py

Lines 137 to 139 in 2534193

	#: user properties is a list of tuples (name, value) that holds user
	#: defined properties of the test
	self.user_properties = user_properties

This makes me nervous when using it in plugins, e.g. to pass Hypothesis statistics around in HypothesisWorks/hypothesis#1577. My code handles either a list or a tuple here, but it would be nice to - one way or another - make the code and the documentation consistent.

[RonnyPfannschmidt]

https://github.com/pytest-dev/pytest/search?q=user_properties&unscoped_q=user_properties lists the instantiation sites

the declaration as is is clearly mistake, it should use None in the argument spec and create a list as default

[Zac-HD]

self.user_properties = list(user_properties) would also work.

[RonnyPfannschmidt]

@Zac-HD indeed, however i beleive it fits python expectations better if the original reference is used if possible

[Zac-HD]

Sure - I was thinking about users who might currently be passing a tuple, but given the .append calls I doubt that would work at the moment anyway!