Parametrized test fails with fixture named "request"

[pytestbot]

Originally reported by: Veeti Paananen (BitBucket: veeti, GitHub: veeti)

• Bitbucket: https://bitbucket.org/pytest-dev/pytest/issue/611

---

import pytest

@pytest.fixture
def request():
    return 123

@pytest.mark.parametrize('param', [1, 2, 3])
def test_stuff(request, param):
    # test stuff
    assert True

Fails with:

    def get_direct_param_fixture_func(request):
>       return request.param
E       AttributeError: 'int' object has no attribute 'param'

[pytestbot]

Original comment by Anatoly Bubenkov (BitBucket: bubenkoff, GitHub: bubenkoff):

---

you've overridden the default request fixture, which you should not do
use other name

[spaceone]

#794

[blueyed]

There should be a RuntimeError or something similar in this case, explaining that the request fixture cannot be overridden.

[spaceone]

are there other restricted names?

[hpk42]

i think "request" is the only real restriction as it serves a purpose for interactions between test or fixture functions and the pytest core. Treating "request" as an illegal name for fixture functions is possible but then again, it's probably used here and there and some might "decorate" the internal request fixture to provide more attributes. Maybe we could generate a warning and then outlaw it with pytest-3.0 or so.

[Zac-HD]

We should try to do this in time for 4.0