Add typing for FixtureRequest.param #10133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nipunn1313
force-pushed
the
add_param_type
branch
from
259ebc8 to
ed12c9a
Compare
For now, mark it as Any until pytest-dev#8073 is solved Fixes pytest-dev#9514
nipunn1313
force-pushed
the
add_param_type
branch
from
ed12c9a to
895164c
Compare
Member
|
Failures in 3.11 can be ignored as they have been fixed by #10132. |
nicoddemus
reviewed
Jul 14, 2022
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
nicoddemus
approved these changes
Jul 14, 2022
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
LGTM, thanks!
I will leave to @bluetech to given the final approve/merge. 😁
Member
|
I wonder how tricky it would actually be to have the requests class getattr return a bound generic of the subrequest |
bluetech
approved these changes
Jul 14, 2022
Member
bluetech
left a comment
bluetech
left a comment
There was a problem hiding this comment.
Seems fine to me as a stop gap.
I added a suggestion for a comment that makes the situation clear, for when we properly tackle this in the future.
Co-authored-by: Ran Benita <ran@unusedvar.com>
Member
|
Thanks @nipunn1313! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, mark it as Any until #8073 is solved
Closes #9514
(added a type annotation in the file to prove it works)
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.AUTHORSin alphabetical order.