fix #10342: put location into warning exceptions#10343
Merged
RonnyPfannschmidt merged 2 commits intopytest-dev:mainfrom Oct 7, 2022
Merged
Conversation
as the warning systems own warn_explicit looses the information we add them explicitly to the warning exceptions
nicoddemus
approved these changes
Oct 6, 2022
Member
nicoddemus
left a comment
There was a problem hiding this comment.
I suppose this also needs a changelog, as improvement?
Member
Author
|
It's unreleased, so I consider it part of the initial change |
Member
|
Fair enough, did not realize that. 👍 |
Member
Author
|
@The-Compiler i'd like to get your input before merging |
Member
|
I wanted to try this by installing Is your branch outdated or something, or is that just a setuptools-scm thing? |
Member
Author
|
@The-Compiler i believe that i didn't push the tags to my repo, let me fix |
Member
Author
|
@The-Compiler updated |
The-Compiler
approved these changes
Oct 7, 2022
Member
The-Compiler
left a comment
There was a problem hiding this comment.
Great idea with only adding it if warnings are exceptions! Only a small suggestion, but looks good to go.
Co-authored-by: Florian Bruhin <me@the-compiler.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as the warning systems own warn_explicit looses the information we add them explicitly to the warning exceptions
@The-Compiler this should resolve the issue you noted
closes #10342