recwarn: let base exceptions propagate through pytest.warns again
#11920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
bluetech
added
the
needs backport
mgorny
reviewed
Feb 5, 2024
Comment on lines
+306
to
+309
| # BaseExceptions like pytest.{skip,fail,xfail,exit} or Ctrl-C within | ||
| # pytest.warns should *not* trigger "DID NOT WARN" and get suppressed | ||
| # when the warning doesn't happen. Control-flow exceptions should always | ||
| # propagate. |
Contributor
There was a problem hiding this comment.
Well, technically I see some packages (trio) using with pytest.raises(GeneratorExit) but it's a corner case, so I'm not going to argue.
nicoddemus
approved these changes
Feb 12, 2024
bluetech
added
backport 8.0.x
and removed
needs backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11907.