Update terminal.py to fix #11777

[HolyMagician03-UMich]

Increases width for short test summary info to reflect verbosity settings. Temporarily resolves #11777

[HolyMagician03-UMich]

Hi! Can I get some opinion on what the available_width should be set to? Right now it's hard-coded to 500, so I imagine that if the list gets longer, the same issue will occur again.

Also, this is the first time I'm contributing to an open-source project, so please let me know what I'm missing in this commit. Thanks!

[nicoddemus]

Hi! Can I get some opinion on what the available_width should be set to? Right now it's hard-coded to 500, so I imagine that if the list gets longer, the same issue will occur again.

I think in this case we do not want to call _format_trimmed at all, leaving the string unchanged.

[nicoddemus]

Thanks @HolyMagician03-UMich!

Besides my comments, please add a new test to test_terminal.py to test the new behavior.

You will need to monkeypatch running_on_ci to always return False in order to ensure the test is testing the -vv flag when running on GitHub actions.

[HolyMagician03-UMich]

Hi! It seems that right now test_line_with_reprcrash is failing because the config object is not initialized with a option.verbose field. Would it be ok for me to modify the config class and give it a verbose of 0? It'll be similar to line 2460 - 2466 of the test_terminal.py in the previous commit, just with a verbosity value of 0.

[nicoddemus]

Would it be ok for me to modify the config class and give it a verbose of 0?

You mean the stub config object used in the test? Yes please go ahead.

[nicoddemus]

@HolyMagician03-UMich took the liberty of simplifying this test. 👍

[nicoddemus]

Thanks @HolyMagician03-UMich!

[HolyMagician03-UMich]

@nicoddemus Thank you for taking the time to review these changes!

[nicoddemus]

Note to self: squash before merging.

I will leave this open for a few more days in case others want to review it.