[pylint] Fix consider-using-sys-exit, use-yield-from, and implicit-str-concat#12379
Conversation
df6b67c to
204568c
Compare
bluetech
left a comment
There was a problem hiding this comment.
IMO, the pointless-x-statement changes don't really improve things, I'd leave it out (but I don't feel strongly about this).
I think there is some confusion in the commit subject [pylint 'implicit-str-concat'] Use zip when iterating on two iterators.
Other than that LGTM, thanks!
9aff37f to
741f92a
Compare
Removed (the benefit would be to be able to see new violations without having low values warning, I agree that the diff is not much better). Either ruff did not catch them or they filtered this when in a pytest.raises / unitest.assertRaises, which make sense.
Yeah, nice catch, probably reused an old message without updating properly, fixed. |
consider-using-sys-exit, use-yield-from, implicit-str-concat and pointless-x-statementconsider-using-sys-exit, use-yield-from, and implicit-str-concat
ebfea87 to
908e112
Compare
Follow-up to #12172