Skip to content

[pylint] Fix consider-using-sys-exit, use-yield-from, and implicit-str-concat#12379

Merged
Pierre-Sassoulas merged 4 commits intopytest-dev:mainfrom
Pierre-Sassoulas:more-pylint-fixes
May 29, 2024
Merged

[pylint] Fix consider-using-sys-exit, use-yield-from, and implicit-str-concat#12379
Pierre-Sassoulas merged 4 commits intopytest-dev:mainfrom
Pierre-Sassoulas:more-pylint-fixes

Conversation

@Pierre-Sassoulas
Copy link
Member

Follow-up to #12172

Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the pointless-x-statement changes don't really improve things, I'd leave it out (but I don't feel strongly about this).

I think there is some confusion in the commit subject [pylint 'implicit-str-concat'] Use zip when iterating on two iterators.

Other than that LGTM, thanks!

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the more-pylint-fixes branch 2 times, most recently from 9aff37f to 741f92a Compare May 29, 2024 11:31
@Pierre-Sassoulas
Copy link
Member Author

IMO, the pointless-x-statement changes don't really improve things, I'd leave it out (but I don't feel strongly about this).

Removed (the benefit would be to be able to see new violations without having low values warning, I agree that the diff is not much better). Either ruff did not catch them or they filtered this when in a pytest.raises / unitest.assertRaises, which make sense.

I think there is some confusion in the commit subject [pylint 'implicit-str-concat'] Use zip when iterating on two iterators.

Yeah, nice catch, probably reused an old message without updating properly, fixed.

@Pierre-Sassoulas Pierre-Sassoulas changed the title [pylint] Fix consider-using-sys-exit, use-yield-from, implicit-str-concat and pointless-x-statement [pylint] Fix consider-using-sys-exit, use-yield-from, and implicit-str-concat May 29, 2024
@Pierre-Sassoulas Pierre-Sassoulas merged commit 0ba3e91 into pytest-dev:main May 29, 2024
@Pierre-Sassoulas Pierre-Sassoulas deleted the more-pylint-fixes branch May 29, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants