unittest: fix assertion errors on unittest reruns #12436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes unittest test reruns when using plugins like pytest-rerunfailures. The `instance` property uses AttributeError to check if the instance needs to be initialized, so `del` is the correct way to clear it, not setting to `None`. Regressed in 8.2.2.
bluetech
force-pushed
the
unittest-rerun-assertion
branch
from
d839e0c to
de47b73
Compare
nicoddemus
approved these changes
Jun 7, 2024
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Nice, thanks for tackling this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes unittest test reruns when using plugins like pytest-rerunfailures.
The
instanceproperty uses AttributeError to check if the instance needs to be initialized, sodelis the correct way to clear it, not setting toNone.Regressed in 8.2.2.
Fix #12424