-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix #12426: adds warning to empty usefixtures. #12439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+4
−1
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b95e85a
warns when usefixtures is empty
JiajunXu2 b356bd5
Merge branch 'main' of https://github.com/JiajunXu2/pytest
JiajunXu2 2f9c634
Merge branch 'pytest-dev:main' into main
JiajunXu2 1507213
Changed _getusefixturesnames to include location
JiajunXu2 e261145
Updated changelog to include fixture improvement
JiajunXu2 5dd4d43
Merge branch 'fix-issue-fixtures'
JiajunXu2 7896d00
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c2322b5
Update 12426.improvement.rst
JiajunXu2 b5b2e3d
Update changelog/12426.improvement.rst
JiajunXu2 2c74288
Update src/_pytest/fixtures.py
JiajunXu2 3bf2639
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 616c735
removed location retrieval from _getusefixturesnames
JiajunXu2 05f7865
Changed node.warn to marker_node.warn
JiajunXu2 f417379
Merge branch 'fix-issue-fixtures'
JiajunXu2 d8c56e5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| A warning is now issued when :ref:`pytest.mark.usefixtures ref` is used without specifying any fixtures. Previously, empty usefixtures markers were silently ignored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need a automated test for this behavior and