[PR #12508/9947ec3a backport][8.2.x] 🧪🚑 Pass a Codecov config to the action @ GHA#12513
Merged
The-Compiler merged 1 commit into8.2.xfrom Jun 21, 2024
Conversation
The #11921 update broke uploading coverage of the `main` branch (or any in-repo pushes for that matter) to Codecov 4 months ago. Version 4 requires an upload token to be provided and since there was no configuration for it, the upload was failing. But the step itself was showing up as successful due to `fail_ci_if_error: true` being set. The error is visible in the console output, though. This patch flips the setting to `fail_ci_if_error: false` and sets the Codecov upload token in the config in clear text. The non-secret part allows the PRs uploads to be more stable. Co-authored-by: Ronny Pfannschmidt <opensource@ronnypfannschmidt.de> (cherry picked from commit 9947ec3)
The-Compiler
approved these changes
Jun 21, 2024
The-Compiler
deleted the
patchback/backports/8.2.x/9947ec3ad1a0fb9f85b092a50b0866b3870e37ad/pr-12508
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #12508 as merged into main (9947ec3).
The #11921 update broke uploading coverage of the
mainbranch (or any in-repo pushes for that matter) to Codecov 4 months ago. Version 4 requires an upload token to be provided and since there was no configuration for it, the upload was failing. But the step itself was showing up as successful due tofail_ci_if_error: truebeing set. The error is visible in the console output, though.This patch flips the setting to
fail_ci_if_error: falseand sets the Codecov upload token in the config in clear text. The non-secret part allows the PRs uploads to be more stable.