Fix disable_test_id_escaping_and_forfeit_all_rights_to_community_support option when using pytest.param(..., id="...")#12861
Merged
nicoddemus merged 6 commits intopytest-dev:mainfrom Oct 9, 2024
Conversation
…port` option when using pytest.param(..., id="...")
psf-chronographer
bot
added
the
bot:chronographer:provided
RonnyPfannschmidt
approved these changes
Oct 7, 2024
Member
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
i like this
as the option is intentionally foot-gun named i consider this as not a breaking change, but that is very debatable and i want to get input from the others
Co-authored-by: Ronny Pfannschmidt <opensource@ronnypfannschmidt.de>
nicoddemus
approved these changes
Oct 7, 2024
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
I don't think it is a breaking change at all, as it is a bugfix because clearly the option should have been considered also for parametrized test ids.
Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
Member
|
Its kind of a breaking change as we inadvertedly change test ids of affected tests |
…s_to_community_support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9037 .
The additional test cases were implemented in almost the same way as the existing similar test cases.
closes #XYZWto the PR description and/or commits (whereXYZWis the issue number). See the github docs for more information.changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.AUTHORSin alphabetical order.