[pylint consider-using-any-or-all] Fix all detected issues#12924
Closed
Pierre-Sassoulas wants to merge 6 commits intopytest-dev:pre-commit-ci-update-configfrom
Closed
[pylint consider-using-any-or-all] Fix all detected issues#12924Pierre-Sassoulas wants to merge 6 commits intopytest-dev:pre-commit-ci-update-configfrom
Pierre-Sassoulas wants to merge 6 commits intopytest-dev:pre-commit-ci-update-configfrom
Conversation
updates: - [github.com/astral-sh/ruff-pre-commit: v0.6.9 → v0.7.0](astral-sh/ruff-pre-commit@v0.6.9...v0.7.0) - [github.com/pre-commit/mirrors-mypy: v1.11.2 → v1.12.1](pre-commit/mirrors-mypy@v1.11.2...v1.12.1) - [github.com/tox-dev/pyproject-fmt: 2.3.1 → 2.4.3](tox-dev/pyproject-fmt@2.3.1...2.4.3)
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>
Pierre-Sassoulas
added
the
skip news
Member
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
I keep getting the impression pylint keeps overdoing it on every step
src/_pytest/mark/__init__.py
Outdated
|
|
||
| return False | ||
| return any( | ||
| all(mark.kwargs.get(k, NOT_SET) == v for (k, v) in kwargs.items()) |
Member
There was a problem hiding this comment.
In nesting it looks worse
Member
Author
There was a problem hiding this comment.
Right, opened a pylint issue to address this.
Pierre-Sassoulas
force-pushed
the
pylint-optimization
branch
from
bf59ed6 to
602adde
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
05b72ee to
b22f8af
Compare
Pierre-Sassoulas
force-pushed
the
pre-commit-ci-update-config
branch
2 times, most recently
from
cf6c0da to
607b9f7
Compare
Member
Author
|
I'll have to open a new PR because the target branch disappeared :/ (already got me once, gitlab is dealing with this better and just change the target branch automatically, here I can't even do that myself after the fact) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require #12910 to be merged first. The first commit is a small optimization, the second commit is more opinionated / about style.