Allow hiding a parameter set from test name#13229
Allow hiding a parameter set from test name#13229nicoddemus merged 11 commits intopytest-dev:mainfrom
Conversation
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
The edge cases are well handled
We might want to bikeshed on whether to use explicit None vs missing instead of a new singleton
|
@RonnyPfannschmidt There are currently no public Are there any other requirements before merge? If not, then merge when ready :) |
|
Thanks for the elaboration 👍 Id like to see the input of some more core members before merge |
|
@Zac-HD @The-Compiler @jakkdl [pinging random members] Would anyone be willing to also review the PR? |
|
Please avoid eagerly pinging volunteers I understand the desire to finally Lan and previously have been in the same position |
nicoddemus
left a comment
There was a problem hiding this comment.
Great work!
Left a few comments related mostly to docs.
src/_pytest/python.py
Outdated
| ``pytest.HIDDEN_PARAM`` means to hide the parameter set | ||
| from the test name. |
There was a problem hiding this comment.
This section is shown here: https://pytest--13229.org.readthedocs.build/en/13229/reference/reference.html#pytest.Metafunc.parametrize
Although a bit hidden, perhaps it helps to show the version where this was added, and mentioning the restriction of it being used at most 1 time:
| ``pytest.HIDDEN_PARAM`` means to hide the parameter set | |
| from the test name. | |
| .. versionadded: 8.4 | |
| ``pytest.HIDDEN_PARAM`` means to hide the parameter set | |
| from the test name. Can only be used at most 1 time, as | |
| test names need to be unique. |
Also HIDDEN_PARAM should appear under the Constants at the top of the page, and then the pytest.HIDDEN_PARAM should be a link to it.
Also it should be mentioned here: https://pytest--13229.org.readthedocs.build/en/13229/reference/reference.html#pytest-param
64b14f4 to
72b3441
Compare
|
@nicoddemus done, please review again |
|
@RonnyPfannschmidt could you please review the PR again? Docs should be ok now |
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
|
@webknjaz done, please check again |
|
I'll let someone else approve. |
nicoddemus
left a comment
There was a problem hiding this comment.
LGTM, thanks @Anton3!
I will leave it open for a few more days to give others a chance to review/chime in.
|
Thanks again @Anton3! |
Closes #13228