fix: support TerminalReporter.isatty being called

[not-my-profile]

Fixes #13461.

[RonnyPfannschmidt]

Outside impact is unclear as others may be using the api as is

We may need to introduce a bool wrapper that support direct checks and calling to obtain the underlying boolean

[RonnyPfannschmidt]

Do we Want to plan for a evenual deprecation of the non call variant?

[not-my-profile]

you mean by issuing a warning when it's used?

[nicoddemus]

I don't think the churn to plugin authors is worth it, given the support code is small.

But we definitely only want to advertise/document the method variant, of course.

[patchback]

Backport to 8.3.x: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply cba5c4a on top of patchback/backports/8.3.x/cba5c4a98f65fdcfa484749bc06bcde1fb0865bc/pr-13462

Backporting merged PR #13462 into main

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/pytest-dev/pytest.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/8.3.x/cba5c4a98f65fdcfa484749bc06bcde1fb0865bc/pr-13462 upstream/8.3.x

4. Now, cherry-pick PR fix: support TerminalReporter.isatty being called #13462 contents into that branch:

   $ git cherry-pick -x cba5c4a98f65fdcfa484749bc06bcde1fb0865bc

   If it'll yell at you with something like fatal: Commit cba5c4a98f65fdcfa484749bc06bcde1fb0865bc is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x cba5c4a98f65fdcfa484749bc06bcde1fb0865bc

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR fix: support TerminalReporter.isatty being called #13462 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/8.3.x/cba5c4a98f65fdcfa484749bc06bcde1fb0865bc/pr-13462

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[patchback]

Backport to 8.4.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.4.x/cba5c4a98f65fdcfa484749bc06bcde1fb0865bc/pr-13462

Backported as #13483

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.