Testcase reports with a url attribute will now properly write this to…

[fushi]

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

• [*] Target: for bug or doc fixes, target master; for new features, target features;
• [*] Make sure to include one or more tests for your change;
• [*] Add yourself to AUTHORS;
• [*] Add a new entry to CHANGELOG.rst
  • Choose any open position to avoid merge conflicts with other PRs.
  • Add a link to the issue you are fixing (if any) using RST syntax.
  • The pytest team likes to have people to acknowledged in the CHANGELOG, so please add a thank note to yourself ("Thanks @user for the PR") and a link to your GitHub profile. It may sound weird thanking yourself, but otherwise a maintainer would have to do it manually before or after merging instead of just using GitHub's merge button. This makes it easier on the maintainers to merge PRs.

… junitxml

[coveralls]

Coverage increased (+0.002%) to 93.028% when pulling 1b259f7 on fushi:url_attr into 9c45d6c on pytest-dev:master.

[fushi]

Just triggering a rerun of travis with the close/open routine

[coveralls]

Coverage increased (+0.002%) to 93.028% when pulling 1b259f7 on fushi:url_attr into 9c45d6c on pytest-dev:master.

[nicoddemus]

Thanks! According to the junit-plugin schema this is valid on Jenkins, but could you explain your use case better? Do you have custom hooks that add that attribute to test reports?

[fushi]

I do! We're using this to point to where our test artifacts are, so that when you see a failure in phabricator, you can be linked directly to the artifacts in jenkins

[nicoddemus]

@fushi I see, thanks. This seems like a new feature (albeit small), so perhaps this should go into the features branch and be released on 3.1.0? Let's see what others have to say.

Also I wonder how to better document that.

[The-Compiler]

I agree this should go to features.

[nicoddemus]

@fushi could you change the target of this PR to features then?

[flub]

Apparently we can change the target ourselves using the edit button at the top of the page :-)