[wip] reintroduce Warnings on customclass usage#2696
Closed
RonnyPfannschmidt wants to merge 3 commits intopytest-dev:featuresfrom
Closed
[wip] reintroduce Warnings on customclass usage#2696RonnyPfannschmidt wants to merge 3 commits intopytest-dev:featuresfrom
RonnyPfannschmidt wants to merge 3 commits intopytest-dev:featuresfrom
Conversation
Member
|
Changed the target branch to Not sure what this entails right now, I will have to take a look at the collection code more carefully to understand what's going on. CI failed as expected because we turned warnings into errors to avoid breaking test suites that do the same. 😁 |
Member
|
@RonnyPfannschmidt gentle ping. 👍 |
Member
Author
|
@nicoddemus this one is on hiatus, i will resolveit hopefully soon |
Member
Author
|
closing this one as the rebase failed and made more mess than worth it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while resolving i found that we do have quite a mess in there because we register a node as a plugin, which in turn gets parsed for factories
i opted into ignoring plain nodes for factory parsing for now,
but that solution is incomplete
however it seems strictly impossible to implement this bit cleanly without breaking the world,
as introducing a session interaction plugin implementing the needed api