Release 3.3.0 by nicoddemus · Pull Request #2945 · pytest-dev/pytest

nicoddemus · 2017-11-23T20:26:47Z

No description provided.

Fix pytest-dev#2926

Release 3.2.5

We should replace the wiki document to a link to this document now

…p-docs Add Deprecation Roadmap to backward compatibility document

Fix pytest-dev#2939

Fix assertion rewrite to match module names correctly

…scription Handle marks without description

The-Compiler · 2017-11-23T20:43:34Z

Don't have time for a closer look right now, but I got some errors:

With pytest-catchlog still installed:

Traceback (most recent call last):
  File "/usr/lib64/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib64/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/pytest.py", line 73, in <module>
    raise SystemExit(pytest.main())
  File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/_pytest/config.py", line 50, in main
    config = _prepareconfig(args, plugins)
  File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/_pytest/config.py", line 160, in _prepareconfig
    pluginmanager=pluginmanager, args=args)
  File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/pluggy/__init__.py", line 680, in __call__
    return self._hookexec(self, self._nonwrappers + self._wrappers, kwargs)
  File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/pluggy/__init__.py", line 240, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/pluggy/__init__.py", line 234, in <lambda>
    methods, kwargs, specopts=hook.spec_opts, hook=hook
  File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/pluggy/callers.py", line 110, in execute
    gen.send(outcome)
  File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/_pytest/helpconfig.py", line 68, in pytest_cmdline_parse
    config = outcome.get_result()
  File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/pluggy/callers.py", line 54, in get_result
    raise ex[1].with_traceback(ex[2])
  File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/pluggy/callers.py", line 94, in execute
    res = hook_impl.function(*args)
  File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/_pytest/config.py", line 938, in pytest_cmdline_parse
    self.parse(args)
  File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/_pytest/config.py", line 1103, in parse
    self._preparse(args, addopts=addopts)
  File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/_pytest/config.py", line 1068, in _preparse
    self.known_args_namespace = ns = self._parser.parse_known_args(args, namespace=self.option.copy())
  File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/_pytest/config.py", line 552, in parse_known_args
    return self.parse_known_and_unknown_args(args, namespace=namespace)[0]
  File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/_pytest/config.py", line 558, in parse_known_and_unknown_args
    optparser = self._getparser()
  File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/_pytest/config.py", line 537, in _getparser
    arggroup.add_argument(*n, **a)
  File "/usr/lib64/python3.6/argparse.py", line 1348, in add_argument
    return self._add_action(action)
  File "/usr/lib64/python3.6/argparse.py", line 1552, in _add_action
    action = super(_ArgumentGroup, self)._add_action(action)
  File "/usr/lib64/python3.6/argparse.py", line 1362, in _add_action
    self._check_conflict(action)
  File "/usr/lib64/python3.6/argparse.py", line 1501, in _check_conflict
    conflict_handler(action, confl_optionals)
  File "/usr/lib64/python3.6/argparse.py", line 1510, in _handle_conflict_error
    raise ArgumentError(action, message % conflict_string)
argparse.ArgumentError: argument --no-print-logs: conflicting option string: --no-print-logs

Then pytest-instafail breaks:

INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/_pytest/main.py", line 99, in wrap_session
INTERNALERROR>     config._do_configure()
INTERNALERROR>   File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/_pytest/config.py", line 916, in _do_configure
INTERNALERROR>     self.hook.pytest_configure.call_historic(kwargs=dict(config=self))
INTERNALERROR>   File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/pluggy/__init__.py", line 691, in call_historic
INTERNALERROR>     res = self._hookexec(self, self._nonwrappers + self._wrappers, kwargs)
INTERNALERROR>   File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/pluggy/__init__.py", line 240, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook, methods, kwargs)
INTERNALERROR>   File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/pluggy/__init__.py", line 234, in <lambda>
INTERNALERROR>     methods, kwargs, specopts=hook.spec_opts, hook=hook
INTERNALERROR>   File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/pluggy/callers.py", line 115, in execute
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>   File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/pluggy/callers.py", line 54, in get_result
INTERNALERROR>     raise ex[1].with_traceback(ex[2])
INTERNALERROR>   File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/pluggy/callers.py", line 94, in execute
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/pytest_instafail.py", line 33, in pytest_configure
INTERNALERROR>     instafail_reporter = InstafailingTerminalReporter(standard_reporter)
INTERNALERROR>   File "/home/florian/proj/qutebrowser/git/.tox/py36/lib/python3.6/site-packages/pytest_instafail.py", line 43, in __init__
INTERNALERROR>     self._tw = reporter._tw
INTERNALERROR> AttributeError: can't set attribute

After removing that and commenting out some code I have which ties into pytest-catchlog, things seem to run fine so far. Will report back when it's done.

Version info:

platform linux -- Python 3.6.3, pytest-3.2.5.dev208+g49c0c599, py-1.5.2, pluggy-0.5.2
PyQt5 5.9.1 -- Qt runtime 5.9.2 -- Qt compiled 5.9.2
benchmark: 3.1.1 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /home/florian/proj/qutebrowser/git, inifile: pytest.ini
plugins: xvfb-1.0.0, travis-fold-1.2.0, rerunfailures-3.1, repeat-0.4.1, qt-2.2.0, mock-1.6.3, faulthandler-1.3.1, cov-2.5.1, benchmark-3.1.1, bdd-2.18.2, hypothesis-3.30.3

coveralls · 2017-11-23T20:49:24Z

Coverage increased (+0.002%) to 92.711% when pulling aa9a02e on nicoddemus:release-3.3.0 into 49c0c59 on pytest-dev:features.

nicoddemus · 2017-11-23T20:50:33Z

Thanks @The-Compiler!

About pytest-catchlog: good catch, when we merged pytest-catchlog into the core I remember wondering what would happen and what to do about it, but ended up forgetting tackling what to actually do. I think the best solution is to prevent catchlog from being installed at all and issue a warning.
About pytest-instafail, we should make a setter for _tw which issues a deprecation warning, similar to what's done with its getter.

I will go ahead and implement those two solutions and upload a new package.

The-Compiler · 2017-11-23T21:00:14Z

Hmm, I also get failing tests in this file, which uses pytester to run pytest with coverage and then checks the coverage.xml file. It looks like that file doesn't exist anymore suddenly?

The-Compiler · 2017-11-23T21:02:52Z

Bisected to 333a9ad which de-vendors pluggy. I guess that also came with some kind of update to the pluggy being used?

nicoddemus · 2017-11-23T21:04:42Z

Hmm, I also get failing tests in this file, which uses pytester to run pytest with coverage and then checks the coverage.xml file. It looks like that file doesn't exist anymore suddenly?

Which file? coverage.xml? Can you please post a failure traceback?

nicoddemus · 2017-11-23T21:19:24Z

About pytest-instafail, we should make a setter for _tw which issues a deprecation warning, similar to what's done with its getter.

Actually on second thought, I'm reverting the change that deprecated _tw. That change also introduced the public writer attribute (deprecating _tr), but @RonnyPfannschmidt has on numerous occasions since then mentioned he would like eventually get rid of TerminalWriter so making it officially public is a step contrary to that.

The-Compiler · 2017-11-23T21:32:18Z

I opened #2946 for the coverage.xml thing as it probably warrants some deeper investigation.

We eventually want to replace py.io.TerminalWriter (exposed as "_tw" in TerminalReporter) by something else, so deprecating access to "_tw" and making it public as "writer" is contrary to that.

Trying to install pytest-3.3 and pytest-catchlog will result in an option conflicts because both declare the same options.

nicoddemus · 2017-11-23T22:02:36Z

pytest-catchlog is no longer imported from setuptools entry points and a pytest-warning is emitted instead (95de11a).
TerminalWriter._tw is back, effectively reverting Deprecate TerminalReporter._tw #2803 and Deprecate TerminalReporter._tw #2804 (05cfdcc).

coveralls · 2017-11-23T22:27:35Z

Coverage decreased (-0.0008%) to 92.708% when pulling 95de11a on nicoddemus:release-3.3.0 into 49c0c59 on pytest-dev:features.

nicoddemus · 2017-11-24T16:43:54Z

Updated pin to include pluggy-0.6. Can you give this a new spin @The-Compiler?

coveralls · 2017-11-24T17:05:01Z

Coverage decreased (-0.0008%) to 92.708% when pulling 0de1a65 on nicoddemus:release-3.3.0 into 49c0c59 on pytest-dev:features.

nicoddemus · 2017-11-24T21:08:01Z

Built the package:

goodboy · 2017-11-25T00:11:34Z

🏍

goodboy · 2017-11-26T02:59:38Z

CHANGELOG.rst

+  <https://github.com/pytest-dev/pytest/issues/2767>`_)
+
+- Pytest no longer supports Python **2.6** and **3.3**. Those Python versions
+  are EOL for some time now and incurr maintanance and compatibility costs on


Typo maintanance should be maintenance.

goodboy · 2017-11-26T03:01:06Z

CHANGELOG.rst

+  previous output style can be set by setting the new ``console_output_style``
+  to ``classic``. (`#2657 <https://github.com/pytest-dev/pytest/issues/2657>`_)
+
+- Match ``warns`` signature to ``raises`` by adding ``match`` keyworkd. (`#2708


typo meant to be keyword

goodboy · 2017-11-26T03:02:02Z

CHANGELOG.rst

+- Pytest now captures and displays output from the standard `logging` module.
+  The user can control the logging level to be captured by specifying options
+  in ``pytest.ini``, the command line and also during individual tests using
+  markers. Also, a ``caplog`` fixture is available that enables users to test


whaaa caplog is dope!

goodboy · 2017-11-26T03:57:16Z

CHANGELOG.rst

+- Refactored internal Python 2/3 compatibility code to use ``six``. (`#2642
+  <https://github.com/pytest-dev/pytest/issues/2642>`_)
+
+- Stop vendoring ``pluggy`` - we're missing out on it's latest changes for not


Heh looks like a typo on my part: should be its.

yikes - based on the number of minor easy to miss typos, we should investigate better news file auto scanning - else we run into them all at once at release time

Or actually start reviewing changelog entries 😉

nicoddemus · 2017-11-26T11:00:27Z

Fixed all typos, thanks @tgoodlet!

coveralls · 2017-11-26T11:25:39Z

Coverage decreased (-0.0008%) to 92.708% when pulling 6eeacab on nicoddemus:release-3.3.0 into 49c0c59 on pytest-dev:features.

The-Compiler

Some comments on the changelog - it runs the qutebrowser testsuite fine now!

The-Compiler · 2017-11-26T22:05:28Z

CHANGELOG.rst

+-------------------------
+
+- Pytest no longer supports Python **2.6** and **3.3**. Those Python versions
+  are EOL for some time now and incurr maintenance and compatibility costs on


incurr -> incur

The-Compiler · 2017-11-26T22:05:57Z

CHANGELOG.rst

+Deprecations and Removals
+-------------------------
+
+- Pytest no longer supports Python **2.6** and **3.3**. Those Python versions


Hm, this sounds like this release really should be 4.0 instead...

Perhaps, but we decided at the time to just increase a minor version instead.

Either way I think it might be too late to change that decision now TBH.

Fair point - I missed the original decision. Let's see how that goes...

The-Compiler · 2017-11-26T22:06:19Z

CHANGELOG.rst

+  ``CallSpec2`` class. (`#2672
+  <https://github.com/pytest-dev/pytest/issues/2672>`_)
+
+- remove ParameterSet.deprecated_arg_dict - its not a public api and the lack


remove -> Remove for consistency.

The-Compiler · 2017-11-26T22:06:49Z

CHANGELOG.rst

+
+- Replace the old introspection code in compat.py that determines the available
+  arguments of fixtures with inspect.signature on Python 3 and
+  funcsigs.signature on Python 2. This should respect __signature__


Might want to add `` around __signature__.

The-Compiler · 2017-11-26T22:07:05Z

CHANGELOG.rst

+  declarations on functions. (`#2267
+  <https://github.com/pytest-dev/pytest/issues/2267>`_)
+
+- Report only once tests with global ``pytestmark`` variable. (`#2549


Report tests with ... only once.

The-Compiler · 2017-11-26T22:07:24Z

CHANGELOG.rst

+  <https://github.com/pytest-dev/pytest/issues/2549>`_)
+
+- Now pytest displays the total progress percentage while running tests. The
+  previous output style can be set by setting the new ``console_output_style``


the new ... -> the new ... setting?

The-Compiler · 2017-11-26T22:08:03Z

CHANGELOG.rst

+  ``err`` can be accessed by attribute. (`#2879
+  <https://github.com/pytest-dev/pytest/issues/2879>`_)
+
+- Add ``capfdbinary`` a version of ``capfd`` which returns bytes from


comma before "a version"

The-Compiler · 2017-11-26T22:08:07Z

CHANGELOG.rst

+  ``readouterr()``. (`#2923
+  <https://github.com/pytest-dev/pytest/issues/2923>`_)
+
+- Add ``capsysbinary`` a version of ``capsys`` which returns bytes from


comma before "a version"

The-Compiler · 2017-11-26T22:08:19Z

CHANGELOG.rst

+  ``readouterr()``. (`#2934
+  <https://github.com/pytest-dev/pytest/issues/2934>`_)
+
+- Implement feature to skip ``setup.py`` files when ran with


The-Compiler · 2017-11-26T22:10:03Z

doc/en/backwards-compatibility.rst

+
+Deprecated in ``3.0``.
+
+Past Releases


Dropping legacy Python support should at least be mentioned here.

nicoddemus · 2017-11-27T12:22:24Z

@The-Compiler thanks for the review, fixed the typos/wording you mentioned. 👍

Just in case you didn't know, you can edit files directly in GH's web interface to fix typos and such, committing directly into my branch. 😉

The-Compiler · 2017-11-27T12:34:00Z

Hm, I indeed didn't think about that! It never worked when trying to clone a PR repo and push there for whatever reason, but I guess the web editor is fine for simple things like this.

coveralls · 2017-11-27T12:45:39Z

Coverage decreased (-0.0008%) to 92.708% when pulling 6cdd851 on nicoddemus:release-3.3.0 into 49c0c59 on pytest-dev:features.

uSpike · 2017-11-27T18:33:59Z

CHANGELOG.rst

+
+- Remove internal ``_preloadplugins()`` function. This removal is part of the
+  ``pytest_namespace()`` hook deprecation. (`#2236
+  <https://github.com/pytest-dev/pytest/issues/2236>`_)


This link is wrong, it should be #2636 if I'm not mistaken...

@uSpike it doesn't really matter, GH automatically redirects it to the appropriate page. 😉

All of our links use the pytest/issues/# form, even if the number actually points to a PR.

I'm confused because if I go to #2236 it's a PR about junitxml, "Change junitxml.py to produce results that comply with Junitxml schema"

@uSpike OH you are right, sorry I misinterpreted what you said.

I will fix this on master after the release, the package has just now finished testing and I would not like to go over the entire process again. 😁

nicoddemus and others added 15 commits November 14, 2017 22:05

Add missing entry to CHANGELOG for 3.2.4

4a0aea2

Remove py<1.5 restriction

dd6c534

Fix pytest-dev#2926

Preparing release version 3.2.5

a220a40

Merge pull request pytest-dev#2927 from nicoddemus/release-3.2.5

74aaf91

Release 3.2.5

Add Deprecation Roadmap to backward compatibility document

f9029f1

We should replace the wiki document to a link to this document now

Add Future/Past Releases section

b0f558d

Merge pull request pytest-dev#2931 from nicoddemus/deprecation-roadma…

77bd0aa

…p-docs Add Deprecation Roadmap to backward compatibility document

Fix assertion rewrite to match module names correctly

c8d52b6

Fix pytest-dev#2939

Merge pull request pytest-dev#2940 from nicoddemus/rewrite-bug-2939

8df7ed1

Fix assertion rewrite to match module names correctly

Handle marks without description

5e71ffa

Minor formatting change in CHANGELOG

378eb5d

Merge pull request pytest-dev#2943 from Perlence/fix-marks-without-de…

27935eb

…scription Handle marks without description

Merge remote-tracking branch 'upstream/master' into release-3.3.0

f50ace7

Remove vendoring import from tasks/__init__

e97c774

Preparing release version 3.3.0

aa9a02e

nicoddemus requested review from RonnyPfannschmidt and The-Compiler November 23, 2017 20:26

nicoddemus changed the base branch from master to features November 23, 2017 20:27

Fix linting in CHANGELOG

0ddd3e2

The-Compiler mentioned this pull request Nov 23, 2017

Failing pytester tests with features branch #2946

Closed

nicoddemus mentioned this pull request Nov 23, 2017

Deprecate TerminalReporter._tw #2803

Closed

Revert making TerminalWriter public in TerminalReporter plugin

05cfdcc

We eventually want to replace py.io.TerminalWriter (exposed as "_tw" in TerminalReporter) by something else, so deprecating access to "_tw" and making it public as "writer" is contrary to that.

Block pytest-catchlog and issue a warning

95de11a

Trying to install pytest-3.3 and pytest-catchlog will result in an option conflicts because both declare the same options.

Update pluggy pin to pluggy>=0.5,<0.7 after pluggy-0.6 release

0de1a65

RonnyPfannschmidt approved these changes Nov 25, 2017

View reviewed changes

goodboy reviewed Nov 26, 2017

View reviewed changes

Fix typos in CHANGELOG

6eeacab

goodboy approved these changes Nov 26, 2017

View reviewed changes

The-Compiler requested changes Nov 26, 2017

View reviewed changes

CHANGELOG and docs changes requested during review

6cdd851

The-Compiler approved these changes Nov 27, 2017

View reviewed changes

uSpike reviewed Nov 27, 2017

View reviewed changes

nicoddemus merged commit 67ad0fa into pytest-dev:features Nov 27, 2017

nicoddemus deleted the release-3.3.0 branch November 27, 2017 21:37

nonylene mentioned this pull request Nov 28, 2017

Set VIRTUAL_ENV enviroment variable in activate_this.py pypa/virtualenv#1057

Merged

nicoddemus mentioned this pull request Nov 30, 2017

pytest 3.3: TerminalReporter.writer removed without deprecating it first #2984

Closed


		Deprecated in ``3.0``.

		Past Releases

Uh oh!

Conversation

nicoddemus commented Nov 23, 2017

Uh oh!

The-Compiler commented Nov 23, 2017

Uh oh!

coveralls commented Nov 23, 2017

Uh oh!

nicoddemus commented Nov 23, 2017

Uh oh!

The-Compiler commented Nov 23, 2017

Uh oh!

The-Compiler commented Nov 23, 2017

Uh oh!

nicoddemus commented Nov 23, 2017

Uh oh!

nicoddemus commented Nov 23, 2017

Uh oh!

The-Compiler commented Nov 23, 2017

Uh oh!

nicoddemus commented Nov 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Nov 23, 2017

Uh oh!

nicoddemus commented Nov 24, 2017

Uh oh!

coveralls commented Nov 24, 2017

Uh oh!

nicoddemus commented Nov 24, 2017

Uh oh!

goodboy commented Nov 25, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicoddemus commented Nov 26, 2017

Uh oh!

coveralls commented Nov 26, 2017

Uh oh!

The-Compiler left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicoddemus commented Nov 23, 2017 •

edited

Loading

The-Compiler commented Nov 27, 2017 •

edited

Loading