Reset reference to failed test frame before each test executes#3384
Merged
nicoddemus merged 3 commits intopytest-dev:masterfrom Apr 12, 2018
Merged
Reset reference to failed test frame before each test executes#3384nicoddemus merged 3 commits intopytest-dev:masterfrom
nicoddemus merged 3 commits intopytest-dev:masterfrom
Conversation
Otherwise we will keep the last failed exception around forever Related to pytest-dev#2798
RonnyPfannschmidt
approved these changes
Apr 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2798. Not entirely because I was not able to remove the cyclic references which seem to be caused by the traceback objects being kept around; those cycles will be eventually be claimed by the garbage collector, at least (with the previous code that was not even possible).