Merged
Conversation
nicoddemus
requested changes
Jun 21, 2018
changelog/3605.bugfix.rst
Outdated
| @@ -0,0 +1 @@ | |||
| unpack marks from parameterization to prevent the markdecorator missmatch bug. | |||
Member
There was a problem hiding this comment.
How can we phrase this in a way that end users (that don't know the internals) can understand? 🤔
| return normalize_mark_list(mark_list) | ||
|
|
||
|
|
||
| def normalize_mark_list(mark_list): |
Member
There was a problem hiding this comment.
Please add a docstring here explaining why this is needed
Member
|
btw, I don't think GitHub looks at the title of the PR to automatically close issues:
https://help.github.com/articles/closing-issues-using-keywords/ 😉 edit: I just noticed that your last commit does include "fix " so this is of course fine. 😁 |
1445a87 to
643e5a9
Compare
nicoddemus
approved these changes
Jun 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
just a guideline):
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.masterbranch for bug fixes, documentation updates and trivial changes.featuresbranch for new features and removals/deprecations.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
AUTHORSin alphabetical order;