Collect any tests from a package's __init__.py

[jonozzz]

Fixes #3773

[nicoddemus]

Thanks @jonozzz, could you please add a test and a CHANGELOG entry?

[nicoddemus]

Restarting CI manually due to Travis hiccup

[coveralls]

Coverage increased (+0.05%) to 92.528% when pulling d0bd01b on jonozzz:fix-3773 into 4d8903f on pytest-dev:master.

[nicoddemus]

Missing a test here, gentle ping 😁

[jonozzz]

@nicoddemus I'm actually waiting on @deeechun to answer. I don't think this was possible in pre-3.7.0, wasn't it?

[nicoddemus]

I can get tests in __init__.py the issue in 3.6.4:

project/
  /tests
    test.py  # contains a single test
  __init__.py  # contains a single test

Running this in 3.6.4 gives:

λ pytest -v -o python_files=*.py
============================= test session starts =============================
...
collected 2 items

__init__.py::test_on_package PASSED                                      [ 50%]
tests/test_basic.py::test PASSED                                         [100%]

========================== 2 passed in 0.05 seconds ===========================

And on master:

 λ pytest -v -o python_files=*.pygit
============================= test session starts =============================
...
collected 0 items

======================== no tests ran in 0.03 seconds =========================

The key thing to remember is to set python_files=*.py.

[nicoddemus]

Oh I just saw that @deeechun replied with basically the same thing. 😁

[RonnyPfannschmidt]

as is this isnt acceptable, since it doesn't check if the filenames is acceptable and might cause surprises for people that have objects with fitting names in packages

[nicoddemus]

Ahh good catch @RonnyPfannschmidt. Just to be clear you mean to change this bit to something like:

init_module = this_path.join("__init__.py")
if init_module.check(file=1) and init_module.match(self.config.getini('python_files')):
    yield Module(init_module, self)

?

[RonnyPfannschmidt]

we should reuse the filename matching and we dont need to check for existence anymore

[nicoddemus]

Right, thanks!

[jonozzz]

Well, the __init__.py is hardcoded at:

pytest/src/_pytest/python.py

Line 204 in d0bd01b

for pat in parent.config.getini("python_files") + ["__init__.py"]:

If you remove that, then you have to explicitly add the __init__.py pattern to "python_files" to enable the Package collection. I'm not sure what's the best way to look for packages but also not duplicate the filename matching.

[nicoddemus]

Gentle ping here? I'm not sure if it is worth reusing the filename matching for __init__ files, which is what I got from @RonnyPfannschmidt's comment.

[RonnyPfannschmidt]

packages have different behaviours than modules to begin with, so i dont see a problem there

[nicoddemus]

So we can go ahead and use my suggestion?

init_module = this_path.join("__init__.py")
if init_module.check(file=1) and init_module.match(self.config.getini('python_files')):
    yield Module(init_module, self)

[RonnyPfannschmidt]

yes

[nicoddemus]

This was marked as merged but the actual code did not go in; probably some commits from this went into #3861, but the final code does not contain the changes here.