Conversation
| assert isinstance(col, pytest.Module) | ||
| assert col.name == "x.py" | ||
| assert col.parent.parent is None | ||
| assert col.parent.parent.parent is None |
There was a problem hiding this comment.
lets please add add comment here to explain the nesting since it is a tad confusing as of now
There was a problem hiding this comment.
Agreed. Probably checking the name of each parent will also help clarifying things. 👍
There was a problem hiding this comment.
It's pretty simple, it's basically testing to see that the Session's parent is None, which should always be and the nodes have been correctly nested. For a more visual example:
tmpdir
\- subdir
\- __init__.py
\- x.py
Session<>
^
| (parent)
Package<subdir>
^
| (parent)
Module<x>
There was a problem hiding this comment.
Maybe the ASCII diagram could be added to the test's docstring?
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks @jonozzz!
Let's improve the test a bit before merging this
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks for the comment @jonozzz.
I fixed the formatting (it was mixing tabs and spaces apparently) and also improved the test a bit.
| assert isinstance(col, pytest.Module) | ||
| assert isinstance(col.parent, pytest.Package) | ||
| assert isinstance(col.parent.parent, pytest.Session) | ||
| # session is batman (has no parents) |
|
@RonnyPfannschmidt and @blueyed you want to take more time to review this or can we merge it? |
5 participants
The previous fix would basically bypass the if block because the return value would always be a list.