Skip to content

fix_1126, 3547 - junit xml schema violation#3808

Closed
rustyhowell wants to merge 1 commit intopytest-dev:masterfrom
rustyhowell:master
Closed

fix_1126, 3547 - junit xml schema violation#3808
rustyhowell wants to merge 1 commit intopytest-dev:masterfrom
rustyhowell:master

Conversation

@rustyhowell
Copy link

Junit has changed the xsd. Testcase no longer has file or line attrs.
Testsuite's attr "skips" has been renamed to "skipped"

This commit will fix the attr name or comment out the deleted attrs

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
just a guideline):

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Target the master branch for bug fixes, documentation updates and trivial changes.
  • Target the features branch for new features and removals/deprecations.
  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS in alphabetical order;

Junit has changed the xsd. Testcase no longer has file or line attrs.
Testsuite's attr "skips" has been renamed to "skipped"

This commit will fix the attr name or comment out the deleted attrs
@RonnyPfannschmidt
Copy link
Member

please run the black pre-commit hook to be in line with the expected code formatting

also its not quite clear to me how to pull this in, as even tho it fixes actual issues, its a breaking change due to following breaking changes in the spec

CC @nicoddemus

@rustyhowell
Copy link
Author

@RonnyPfannschmidt , your're right. This is a breaking change. See my comments on #3777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants