fix_1126, 3547 - junit xml schema violation#3808
Closed
rustyhowell wants to merge 1 commit intopytest-dev:masterfrom
rustyhowell:master
Closed
fix_1126, 3547 - junit xml schema violation#3808rustyhowell wants to merge 1 commit intopytest-dev:masterfrom rustyhowell:master
rustyhowell wants to merge 1 commit intopytest-dev:masterfrom
rustyhowell:master
Conversation
Junit has changed the xsd. Testcase no longer has file or line attrs. Testsuite's attr "skips" has been renamed to "skipped" This commit will fix the attr name or comment out the deleted attrs
Member
|
please run the black pre-commit hook to be in line with the expected code formatting also its not quite clear to me how to pull this in, as even tho it fixes actual issues, its a breaking change due to following breaking changes in the spec CC @nicoddemus |
Author
|
@RonnyPfannschmidt , your're right. This is a breaking change. See my comments on #3777 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Junit has changed the xsd. Testcase no longer has file or line attrs.
Testsuite's attr "skips" has been renamed to "skipped"
This commit will fix the attr name or comment out the deleted attrs
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
just a guideline):
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.masterbranch for bug fixes, documentation updates and trivial changes.featuresbranch for new features and removals/deprecations.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
AUTHORSin alphabetical order;