Fixtures during teardown can use capsys and capfd to get output from tests#3830
Merged
nicoddemus merged 3 commits intopytest-dev:masterfrom Aug 20, 2018
Merged
Conversation
Member
Author
|
cc @trrichard |
RonnyPfannschmidt
approved these changes
Aug 20, 2018
Sup3rGeo
approved these changes
Aug 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem is that the fixtures didn't live up to the promise to properly accumulate output between setup/call/teardown. This works in
3.2because we didn't allow to access the fixture during setup/teardown from the first place, so it didn't need to accumulate any buffer.Follow up to #3066, fixes #3033.