Correct cmdclass for doc: Good Integration Practices#3871
Merged
nicoddemus merged 2 commits intopytest-dev:masterfrom Aug 25, 2018
Merged
Correct cmdclass for doc: Good Integration Practices#3871nicoddemus merged 2 commits intopytest-dev:masterfrom
nicoddemus merged 2 commits intopytest-dev:masterfrom
Conversation
nicoddemus
reviewed
Aug 24, 2018
| # ..., | ||
| tests_require=["pytest"], | ||
| cmdclass={"test": PyTest}, | ||
| cmdclass={"pytest": PyTest}, |
Member
There was a problem hiding this comment.
Isn't this string ("test"/"pytest") the name of the command executed in the next section?
python setup.py test
Contributor
Author
There was a problem hiding this comment.
Earlier in the document, 'test' is created as an alias to 'pytest':
[aliases]
test=pytestThe command doesn't work unless you remove this from setup.cfg or replace that alias with the canonical name in setup.py.
Member
There was a problem hiding this comment.
Ahh right, thanks for the clarification! 👍
nicoddemus
approved these changes
Aug 24, 2018
Member
|
Btw thanks for your first contribution! 🎉 |
Contributor
Author
|
Thanks for responding to a PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #3870
If you follow the guide to this point, the correct key for
cmdclasswill be the canonical name 'pytest' rather than the alias 'test' created in setup.cfg.