Remove dangerous sys.path manipulations in test_pluginmanager#3873
Merged
nicoddemus merged 2 commits intopytest-dev:masterfrom Aug 26, 2018
Merged
Remove dangerous sys.path manipulations in test_pluginmanager#3873nicoddemus merged 2 commits intopytest-dev:masterfrom
nicoddemus merged 2 commits intopytest-dev:masterfrom
Conversation
Noticed these while working in something else
blueyed
approved these changes
Aug 25, 2018
The code in test_pytester has been refactored into a class right above the dead code, and the code has been left there by mistake apparently.
Member
Author
|
Found another one in |
nicoddemus
commented
Aug 25, 2018
| assert imported.data == 42 | ||
|
|
||
|
|
||
| def test_inline_run_clean_sys_paths(testdir): |
Member
Author
There was a problem hiding this comment.
The tests inside this test (!) have been refactored into a test class above this code, but this function (with 3 local functions which are never called) was left by mistake apparently.
Member
There was a problem hiding this comment.
I opened #3875 to try and surface these things better :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed these while working in something else