Skip to content

Travis: use TOXENV=linting for linting stage#3874

Merged
nicoddemus merged 1 commit intopytest-dev:masterfrom
blueyed:improve-pre-commit
Aug 25, 2018
Merged

Travis: use TOXENV=linting for linting stage#3874
nicoddemus merged 1 commit intopytest-dev:masterfrom
blueyed:improve-pre-commit

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 25, 2018

This will run it with --show-diff-on-failure then, and helps to keep
it in line / in a central place.

See https://travis-ci.org/pytest-dev/pytest/jobs/420595379 for an example failure.

Appveyor uses TOXENV=linting already.

This will run it with `--show-diff-on-failure` then, and helps to keep
it in line / in a central place.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 92.639% when pulling 415fcb9 on blueyed:improve-pre-commit into be4b359 on pytest-dev:master.

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seems fine 👍

I wonder if this was done to avoid tox overhead though -- but that's, what, a few seconds?

@asottile
Copy link
Member

oh actually, maybe add skip_install / skip_sdist / whatever the option I'm forgetting to the linting testenv? It seems to still be installing pytest which isn't necessary

@nicoddemus nicoddemus merged commit 71b4995 into pytest-dev:master Aug 25, 2018
@blueyed blueyed deleted the improve-pre-commit branch August 26, 2018 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants