travis: run tests on macOS#3893
Conversation
pytest-dev#3888 (comment) closes pytest-dev#3888 Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
.travis.yml
Outdated
| python: '3.7' | ||
| sudo: required | ||
| dist: xenial | ||
| - language: generic |
There was a problem hiding this comment.
Awesome. 😎
Is python2.7 available on this image? If so, is it worth it to also test on 2.7?
There was a problem hiding this comment.
python2.7 is the system Python. We can include it too.
|
@jirikuncar the build failed with: Can you install Btw, feel free to comment out the other environments until we get OS-X running, so the builds are faster. 👍 |
Codecov Report
@@ Coverage Diff @@
## master #3893 +/- ##
==========================================
+ Coverage 92.58% 92.62% +0.04%
==========================================
Files 51 51
Lines 9960 9961 +1
==========================================
+ Hits 9221 9226 +5
+ Misses 739 735 -4
Continue to review full report at Codecov.
|
.travis.yml
Outdated
| os: osx | ||
| osx_image: xcode9.4 | ||
| sudo: required | ||
| env: TOXENV=py27 |
There was a problem hiding this comment.
Should not be defined in the "included" part probably ("&test-macos").
There was a problem hiding this comment.
It's good to have a default which get changed later.
.travis.yml
Outdated
| - <<: *test-macos | ||
| env: TOXENV=py36 | ||
| install: | ||
| - python3 -m pip install --upgrade --pre tox |
There was a problem hiding this comment.
Doesn't the normal "install" suffice? (also above)
|
@jirikuncar I force-pushed to your branch to remove a temporary commit, hope that's OK. I've fixed the failing test and dropped py36 from OS-X: in my experience Travis OS-X jobs take longer (sometimes a lot longer) to start than plain linux jobs, and I think testing with py27 and py37 is enough to ensure compatibility. 👍 |
|
Thanks everyone for the fast response here! Can I ask whether a patch release will be made soon (e.g. ~1 week timeframe)? We need to decide whether to pin to an earlier pytest or wait for this fix in our own repo. |
|
@jni we strive to make bug fix releases every 2 weeks or so, but we can make an exception and cut a release sooner, no problem. But regardless I would suggest to pin pytest to an earlier version, otherwise your PRs will be broken until then. |
|
@jni I have personally changed my dependency to |
|
Thanks everyone! Yes this episode has taught me that @nicoddemus the reason I was asking is that our project is pretty slow moving at the moment and I can't reliably predict that we will merge a fix before 3.7.4 is out. =P |
Closes #3892
Closes #3888
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
just a guideline):
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.masterbranch for bug fixes, documentation updates and trivial changes.featuresbranch for new features and removals/deprecations.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
Add yourself totrivial change - no codeAUTHORSin alphabetical order;