Remove yield and compatprop

[RonnyPfannschmidt]

this pr removes a whole set of internal breakage by removing a broken feature as well as compat properties which are also deprecated since years, just impossibly hard to integrate with the warning system due to their bad_ structure

[coveralls]

Coverage decreased (-0.4%) to 92.196% when pulling 085bd97 on RonnyPfannschmidt:remove-yield-and-compatprop into a605ad4 on pytest-dev:features.

[codecov]

Codecov Report

Merging #3898 into features will decrease coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##           features    #3898      +/-   ##
============================================
- Coverage     95.87%   95.82%   -0.05%     
============================================
  Files           111      111              
  Lines         25258    25034     -224     
  Branches       2476     2462      -14     
============================================
- Hits          24215    23990     -225     
- Misses          733      735       +2     
+ Partials        310      309       -1

Flag	Coverage Δ
#docs	29.26% <23.52%> (+0.11%)	⬆️
#doctesting	29.26% <23.52%> (+0.11%)	⬆️
#linting	29.26% <23.52%> (+0.11%)	⬆️
#linux	95.66% <100%> (-0.05%)	⬇️
#nobyte	92.55% <100%> (-0.06%)	⬇️
#numpy	93.28% <100%> (-0.08%)	⬇️
#pexpect	41.6% <76.47%> (-0.06%)	⬇️
#py27	93.88% <100%> (-0.07%)	⬇️
#py34	92.06% <88.23%> (ø)	⬆️
#py35	92.08% <88.23%> (ø)	⬆️
#py36	92.1% <88.23%> (ø)	⬆️
#py37	94.03% <100%> (-0.06%)	⬇️
#trial	93.28% <100%> (-0.08%)	⬇️
#windows	94.07% <100%> (-0.05%)	⬇️
#xdist	93.94% <100%> (-0.03%)	⬇️

Impacted Files	Coverage Δ
testing/python/collect.py	99.15% <ø> (-0.15%)	⬇️
testing/python/fixture.py	99.24% <ø> (-0.01%)	⬇️
testing/test_session.py	96.37% <ø> (-0.18%)	⬇️
src/pytest.py	100% <ø> (ø)	⬆️
src/_pytest/fixtures.py	97.38% <ø> (-0.02%)	⬇️
src/_pytest/compat.py	96.96% <ø> (ø)	⬆️
testing/test_nose.py	98.86% <ø> (-0.07%)	⬇️
testing/test_pdb.py	98.99% <ø> (-0.03%)	⬇️
src/_pytest/nodes.py	94.11% <ø> (-0.58%)	⬇️
src/_pytest/nose.py	97.22% <ø> (-0.61%)	⬇️
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d86247...7eb28f9. Read the comment docs.

[asottile]

wow, didn't even know yield tests were a thing -- I guess parametrize for the most part obsoletes them?

[RonnyPfannschmidt]

@asottile they where used for more than parameterization originally, but ever since collection and test running are not interleaved, they are severely broken wrt setupstate and no longer usable for anything that parameterize doesnt do better

[nicoddemus]

@RonnyPfannschmidt now that we have properly deprecated those, I believe it is easier to reject this PR and pick this up again after 4.1. 😁

[RonnyPfannschmidt]

i'll take a look in a bit wrt reenabling it - the warnings stuff has quite some conflicts but afterwards it should be clean to keep around

[nicoddemus]

Oh OK, sounds good! 👍

I will update the milestone to 4.1 then (which is when we will effectively remove the code).

[RonnyPfannschmidt]

@nicoddemus ping

[RonnyPfannschmidt]

@nicoddemus i have no idea why the garbage collect test falls over

[nicoddemus]

Run test_request_garbage in a subprocess

This test fails on occasion, and one suspicion is that some state from
the outer pytest might be leaking into the test. Let's see how that fares in CI.

(Heh, my second commit today which changes a test to run in a subprocess 😁 )

[nicoddemus]

py37 failed 😕

[RonnyPfannschmidt]

finally got around fixing - i missed that the test name change would change the filename below