Needless message printed with --failed-first and no failed tests #3853#3912
Merged
nicoddemus merged 4 commits intopytest-dev:featuresfrom Aug 30, 2018
Merged
Needless message printed with --failed-first and no failed tests #3853#3912nicoddemus merged 4 commits intopytest-dev:featuresfrom
nicoddemus merged 4 commits intopytest-dev:featuresfrom
Conversation
…led and no failed tests
Codecov Report
@@ Coverage Diff @@
## features #3912 +/- ##
============================================
+ Coverage 92.2% 92.25% +0.04%
============================================
Files 52 52
Lines 10016 10016
============================================
+ Hits 9235 9240 +5
+ Misses 781 776 -5
Continue to review full report at Codecov.
|
nicoddemus
reviewed
Aug 30, 2018
| @@ -0,0 +1,2 @@ | |||
| Removed ``"run all (no recorded failures)"`` message printed with ``--failed-first`` and ``--last-failed`` when there are no failed tests. | |||
Member
There was a problem hiding this comment.
@dhirensr I took the liberty of updating the CHANGELOG a bit: we don't need to explicitly write about internal details like which tests were updated for example; those are not interesting for final users, which are the public the CHANGELOG is meant for. 😁
nicoddemus
approved these changes
Aug 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.