Improve pre-commit detection for changelog filenames#3957
Merged
asottile merged 1 commit intopytest-dev:masterfrom Sep 8, 2018
asottile:changelog_files
Merged
Improve pre-commit detection for changelog filenames#3957asottile merged 1 commit intopytest-dev:masterfrom asottile:changelog_files
asottile merged 1 commit intopytest-dev:masterfrom
asottile:changelog_files
Conversation
asottile
commented
Sep 7, 2018
| language: script | ||
| files: 'changelog/.*(?<!\.rst)$' | ||
| name: changelog filenames | ||
| language: fail |
Member
Author
There was a problem hiding this comment.
note here that language: fail is a new pre-commit "language"
1 similar comment
nicoddemus
approved these changes
Sep 7, 2018
Codecov Report
@@ Coverage Diff @@
## master #3957 +/- ##
==========================================
+ Coverage 94.48% 94.52% +0.04%
==========================================
Files 107 107
Lines 23651 23651
Branches 2349 2349
==========================================
+ Hits 22347 22357 +10
+ Misses 993 987 -6
+ Partials 311 307 -4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3955
Before: