tests: use unittest.mock with py34+#3967
Merged
blueyed merged 1 commit intopytest-dev:masterfrom Sep 13, 2018
Merged
Conversation
blueyed
force-pushed
the
optional-mock
branch
from
82b115f to
e9ab074
Compare
Codecov Report
@@ Coverage Diff @@
## master #3967 +/- ##
==========================================
+ Coverage 94.48% 94.52% +0.03%
==========================================
Files 107 107
Lines 23651 23654 +3
Branches 2349 2349
==========================================
+ Hits 22347 22359 +12
+ Misses 993 988 -5
+ Partials 311 307 -4
Continue to review full report at Codecov.
|
nicoddemus
approved these changes
Sep 11, 2018
Contributor
Author
|
Meh, running into tox-dev/tox#706 now. |
auvipy
approved these changes
Sep 11, 2018
blueyed
force-pushed
the
optional-mock
branch
from
afa63eb to
99f52bd
Compare
Contributor
Author
|
Squashed, should be good now - although the workaround is a bit unfortunate to have in the first place. |
RonnyPfannschmidt
approved these changes
Sep 11, 2018
Fixes pytest-dev#3965. Has to work around tox-dev/tox#706. No coverage for pluggymaster builds is OK though anyway.
blueyed
force-pushed
the
optional-mock
branch
from
99f52bd to
7537e94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3965.