Introduce deprecations page#3997
Merged
nicoddemus merged 2 commits intopytest-dev:masterfrom Sep 20, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3997 +/- ##
=========================================
- Coverage 94.34% 94.1% -0.25%
=========================================
Files 108 108
Lines 23703 23698 -5
Branches 2353 2350 -3
=========================================
- Hits 22363 22300 -63
- Misses 1021 1075 +54
- Partials 319 323 +4
Continue to review full report at Codecov.
|
laurentbristiel
approved these changes
Sep 19, 2018
Member
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
i like what i see so far, having a detailed documentation is pretty helpfull
Member
Author
|
Ready for review! 👍 |
Member
Author
|
cc @okken |
87a8554 to
c284154
Compare
RonnyPfannschmidt
approved these changes
Sep 20, 2018
Contributor
|
Thanks Bruno. I think it’s a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got the page going, wanted to see what others think.
Documenting the deprecations in the CHANGELOG often is done too briefly, while I believe we should write down the rationale and provide examples on how to update the code. I think when users understand the reasoning behind deprecations they are much more understanding.
Also examples on how to update the code currently are often provided in the docstrings of the features we plan to remove, which will disappear when we effectively remove said feature.
The idea is to keep this page around "forever" as a reference for users which encounter ancient codebases and want to revive them.
fix #3996